Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Security-Policy should not run on --local #1825

Merged
merged 1 commit into from
Apr 7, 2022
Merged

Conversation

azeemshaikh38
Copy link
Contributor

What kind of change does this PR introduce?

Fixes bug introduced in #1579. Security-Policy was never supposed to be run on --local.

(Is it a bug fix, feature, docs update, something else?)

What is the current behavior?

What is the new behavior (if this is a feature change)?**

  • Tests for the changes have been added (for bug fixes/features)

Which issue(s) this PR fixes

NONE

Special notes for your reviewer

Does this PR introduce a user-facing change?

For user-facing changes, please add a concise, human-readable release note to
the release-note

(In particular, describe what changes users might need to make in their
application as a result of this pull request.)

Remove `Security-Policy` from `--local`

@azeemshaikh38 azeemshaikh38 enabled auto-merge (squash) April 7, 2022 18:44
@azeemshaikh38 azeemshaikh38 temporarily deployed to integration-test April 7, 2022 18:45 Inactive
@codecov
Copy link

codecov bot commented Apr 7, 2022

Codecov Report

Merging #1825 (94fd71d) into main (4df16f3) will increase coverage by 3.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1825      +/-   ##
==========================================
+ Coverage   53.54%   56.57%   +3.02%     
==========================================
  Files          73       73              
  Lines        6697     6692       -5     
==========================================
+ Hits         3586     3786     +200     
+ Misses       2865     2654     -211     
- Partials      246      252       +6     

@github-actions
Copy link

github-actions bot commented Apr 7, 2022

Integration tests success for
[94fd71d]
(https://github.com/ossf/scorecard/actions/runs/2110900872)

Copy link
Member

@naveensrinivasan naveensrinivasan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@azeemshaikh38 azeemshaikh38 merged commit 333618d into main Apr 7, 2022
@azeemshaikh38 azeemshaikh38 deleted the azeems/secpol branch April 7, 2022 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants